-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リトライ処理の改善 #172
Merged
Merged
リトライ処理の改善 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Hexa 変更履歴ほしい |
はい |
voluntas
reviewed
Mar 6, 2024
voluntas
requested changes
Mar 6, 2024
CHANGES.md
Outdated
- @Hexa | ||
- [ADD] ハンドラーにリトライ回数を管理するメソッドを追加する | ||
- @Hexa | ||
- [CHANGE] aws への接続時に HTTP ステータスコードが 429 の応答の場合は、指定されたリトライ設定に応じて、再接続を試みるように変更する |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
少し解説追加してほしい、なぜ 429 なのかを簡単にでいいので
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらで追記しました
voluntas
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the retry mechanism in the service handlers (
AmazonTranscribeHandler
,PacketDumpHandler
,SpeechToTextHandler
, andTestHandler
) and the server'screateSpeechHandler
function. The changes introduce a retry count, mutex for thread safety, and methods for updating, getting, and resetting the retry count in the service handlers. The server'screateSpeechHandler
function has been updated to handle retry logic based on the retry count and configuration settings. There are also configuration changes to specify the maximum retries and retry interval.Here are the most significant changes:
Retry Mechanism Enhancement:
amazon_transcribe_handler.go
,packet_dump_handler.go
,speech_to_text_handler.go
,test_handler.go
: IntroducedRetryCount
andmu
(a mutex for thread safety) in the service handlers. Added methodsUpdateRetryCount
,GetRetryCount
, andResetRetryCount
to manage the retry count. These changes enhance the retry mechanism in the service handlers. [1] [2] [3] [4] [5] [6] [7] [8]handler.go
: Updated thecreateSpeechHandler
function to handle retry logic based on the retry count and configuration settings. This change enhances the retry mechanism when creating a speech handler. [1] [2] [3]Configuration Changes:
config.go
,config_example.ini
: Replaced theRetry
configuration withMaxRetry
andRetryIntervalMs
. These changes allow specifying the maximum number of retries and the interval between retries. [1] [2] [3]Error Handling Improvement:
amazon_transcribe.go
,errors.go
: Added aRetry
field to theSuzuError
structure to indicate whether an error is retryable. This change improves error handling by providing more information about the nature of the error. [1] [2]